feat: sortdb detect external blobs#7309
Conversation
Coverage Report for CI Build 27534101156Coverage increased (+0.2%) to 85.899%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions7683 previously-covered lines in 125 files lost coverage.
Coverage Stats
💛 - Coveralls |
benjamin-stacks
left a comment
There was a problem hiding this comment.
This LGTM, but do you know the original reason for open_opts.external_blobs?
I'm asking because if someone so explicitly forced the sortition DB to have internal blobs, than that fact might be an implicit assumption elsewhere.
I believe the history is that external blobs was a later addition to the MARF, and the SortitionDB was so small (comparatively) at that point and not suffering performance issues, that they didn't see a point in forcing it to external blobs. I'm speculating, but that would make sense to me. Otherwise, the MARF handles the "am I external or not" question internally, so it's not something that external callers should be depending on (I would hope that our tests would break if that assumption were false...). |
I believe it's like @cylewitruk-stacks says. Even the index was previously using internal blobs and only later added a migration to move them to external. The squash is already running them externally and it's running at chaintip allright |
Description
A missing piece I forgot to add in the marf-squash-engine PR. marf-squash creates all MARFs with external blobs, so this is needed to make a pruned chainstate work on develop
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)changelog.d/README.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo