refactor: use new variadic concat#7292
Merged
brice-stacks merged 4 commits intoJun 15, 2026
Merged
Conversation
djordon-stacks
approved these changes
Jun 9, 2026
There seems to be a bug in vitest that causes it to stall when there is that failure during setup. The latest v4 version fixes the hang, but the error is hidden. I've opened an issue with `vitest` to fix this.
This gives us the variadic `concat` support needed to merge this PR.
brice-stacks
force-pushed
the
feat/use-variadic-concat
branch
from
9169655 to
919f2b5
Compare
There was a problem hiding this comment.
Pull request overview
Refactors the PoX-5 boot contract to use the new variadic concat form (reducing nested concat expressions) and updates the core-contract-tests JS tooling to versions compatible with the updated Clarinet SDK.
Changes:
- Refactor multiple PoX-5 contract byte-buffer concatenations to use variadic
concatand adjust formatting for readability. - Update
@stacks/clarinet-sdkandvitestversions used bycontrib/core-contract-tests. - Add a changelog entry documenting the PoX-5 variadic
concatupdate.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| stackslib/src/chainstate/stacks/boot/pox-5.clar | Refactors buffer concatenation logic to the new variadic concat and updates related comments/formatting. |
| contrib/core-contract-tests/package.json | Bumps Clarinet SDK and Vitest versions used by contract tests. |
| contrib/core-contract-tests/package-lock.json | Updates the resolved dependency graph for the bumped toolchain versions. |
| changelog.d/use-variadic-concat.changed | Notes the PoX-5 contract refactor to variadic concat. |
Files not reviewed (1)
- contrib/core-contract-tests/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brice-stacks
merged commit b412a83
into
stacks-network:pox-wf-integration
223 of 226 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving this in draft until Clarinet is updated with support so we can properly run the tests.