Skip to content

test: fix flakiness in idle_tenure_extend_active_mining#7285

Merged
brice-stacks merged 2 commits into
stacks-network:developfrom
brice-stacks:fix/flaky-tenure-extend
Jun 15, 2026
Merged

test: fix flakiness in idle_tenure_extend_active_mining#7285
brice-stacks merged 2 commits into
stacks-network:developfrom
brice-stacks:fix/flaky-tenure-extend

Conversation

@brice-stacks

Copy link
Copy Markdown
Contributor

Tenure-change blocks (BlockFound/Extended) roll the timestamp over to now + idle_timeout, while regular blocks derive it from tenure start plus accumulated processing time. With second-level granularity these two formulas can produce equal timestamps, so only assert strict advancement between consecutive regular blocks (where the injected validation delay guarantees it advances). Skip the first block of each tenure and any tenure-change block.

@coveralls

coveralls commented Jun 6, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27151423578

Coverage increased (+0.1%) to 85.823%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 7284 coverage regressions across 126 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

7284 previously-covered lines in 126 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stackslib/src/config/mod.rs 376 68.96%
stackslib/src/net/mod.rs 310 78.05%
stackslib/src/chainstate/stacks/index/storage.rs 286 82.28%
clarity/src/vm/database/clarity_db.rs 268 82.11%
stackslib/src/chainstate/stacks/miner.rs 252 83.45%
stackslib/src/net/inv/epoch2x.rs 235 78.57%
stackslib/src/chainstate/stacks/db/transactions.rs 222 97.16%
stackslib/src/chainstate/nakamoto/mod.rs 203 84.75%
stackslib/src/net/chat.rs 199 93.05%
stackslib/src/chainstate/stacks/db/mod.rs 196 86.23%

Coverage Stats

Coverage Status
Relevant Lines: 224161
Covered Lines: 192381
Line Coverage: 85.82%
Coverage Strength: 18836571.17 hits per line

💛 - Coveralls

Comment thread stacks-node/src/tests/signer/v0/tenure_extend.rs

@cylewitruk-stacks cylewitruk-stacks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@brice-stacks brice-stacks added this pull request to the merge queue Jun 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@brice-stacks brice-stacks added this pull request to the merge queue Jun 15, 2026
Merged via the queue into stacks-network:develop with commit b5cb85c Jun 15, 2026
424 of 427 checks passed
@brice-stacks brice-stacks deleted the fix/flaky-tenure-extend branch June 15, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants