Skip to content

chore: log received non-duplicate blocks only #7256

Open
francesco-stacks wants to merge 1 commit into
stacks-network:developfrom
francesco-stacks:fix/relay-log-only-new-nakamoto-blocks
Open

chore: log received non-duplicate blocks only #7256
francesco-stacks wants to merge 1 commit into
stacks-network:developfrom
francesco-stacks:fix/relay-log-only-new-nakamoto-blocks

Conversation

@francesco-stacks

Copy link
Copy Markdown
Contributor

Description

while debugging a synching pruned node, I noticed that this line was being logged ~210 times/sec for duplicate blocks that the nodes already had stored while synching. I moved it a bit down where it only logs new blocks.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • For new Clarity features or consensus changes, add property tests (see docs/property-testing.md)
  • Changelog fragment(s) or "no changelog" label added (see changelog.d/README.md)
  • Required documentation changes (e.g., rpc/openapi.yaml for RPC endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this May 30, 2026
@francesco-stacks francesco-stacks changed the title feat: log received non-duplicate blocks only chore: log received non-duplicate blocks only May 30, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 26686907790

Coverage increased (+0.07%) to 85.779%

Details

  • Coverage increased (+0.07%) from the base build.
  • Patch coverage: 4 of 4 lines across 1 file are fully covered (100%).
  • 6674 coverage regressions across 118 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

6674 previously-covered lines in 118 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
stackslib/src/config/mod.rs 376 68.96%
stackslib/src/net/mod.rs 311 77.84%
stackslib/src/chainstate/stacks/index/storage.rs 284 82.27%
stackslib/src/chainstate/stacks/miner.rs 258 83.18%
clarity/src/vm/database/clarity_db.rs 244 82.23%
stackslib/src/chainstate/stacks/db/transactions.rs 222 97.16%
stackslib/src/net/inv/epoch2x.rs 213 79.9%
stackslib/src/net/chat.rs 201 93.01%
stackslib/src/chainstate/stacks/db/mod.rs 196 86.23%
stackslib/src/core/mempool.rs 192 86.51%

Coverage Stats

Coverage Status
Relevant Lines: 223465
Covered Lines: 191685
Line Coverage: 85.78%
Coverage Strength: 18900672.06 hits per line

💛 - Coveralls

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts inbound Nakamoto block logging in the relayer so that the “Handle incoming …” info log is emitted only for blocks that are not already present in the local Nakamoto blocks DB, reducing high-volume log spam during sync (especially on pruned nodes).

Changes:

  • Move the “Handle incoming Nakamoto block … obtained via …” info! log to occur after the “already stored” short-circuit check.
  • Keep structured logging (block_id) while avoiding repeated logs for duplicate blocks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants