Skip to content

feat(sfs): extend resource-pool commands with snapshotPolicyId #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GokceGK merged 6 commits into from
May 12, 2026
Merged

feat(sfs): extend resource-pool commands with snapshotPolicyId #1404

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dffec7b
feat(sfs): extend resource-pool commands with snapshotPolicyId
GokceGK May 11, 2026
4981d34
feat(sfs): extend resource-pool commands with snapshotPolicyId
GokceGK May 11, 2026
40eabb9
feat(sfs): extend udpate error handling
GokceGK May 11, 2026
9bbf5eb
Merge branch 'main' into feat/STACKITCLI-394_resource-pool-snapshotPo…
GokceGK May 11, 2026
178cc02
Merge branch 'main' into feat/STACKITCLI-394_resource-pool-snapshotPo…
GokceGK May 12, 2026
4795e72
Merge branch 'main' into feat/STACKITCLI-394_resource-pool-snapshotPo…
GokceGK May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(sfs): extend udpate error handling 
relates to STACKITCLI-394
  • Loading branch information
@GokceGK
GokceGK committed May 11, 2026
commit 40eabb932f31216ead0231fce5f16a42f92805b4
2 changes: 1 addition & 1 deletion internal/cmd/beta/sfs/resource-pool/update/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
snapshotsVisible := flags.FlagToBoolPointer(p, cmd, snapshotsVisibleFlag)
snapshotPolicyId := flags.FlagToStringPointer(p, cmd, snapshotPolicyIdFlag)

if performanceClass == nil && size == nil && ipAcls == nil && snapshotsVisible == nil {
if performanceClass == nil && size == nil && ipAcls == nil && snapshotsVisible == nil && snapshotPolicyId == nil {
return nil, &cliErr.EmptyUpdateError{}
}

Expand Down
1 change: 1 addition & 0 deletions internal/cmd/beta/sfs/resource-pool/update/update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ func TestParseInput(t *testing.T) {
delete(flagValues, ipAclFlag)
delete(flagValues, performanceClassFlag)
delete(flagValues, snapshotsVisibleFlag)
delete(flagValues, snapshotPolicyIdFlag)
}),
isValid: false,
},
Expand Down
Loading