Skip to content

Label-Based resource ownership - ALB and Certificates#1092

Open
meneksece wants to merge 1 commit intofeat/kp/add-alb-ingress-controllerfrom
feat/mc/add-alb-ingress-controller-labels
Open

Label-Based resource ownership - ALB and Certificates#1092
meneksece wants to merge 1 commit intofeat/kp/add-alb-ingress-controllerfrom
feat/mc/add-alb-ingress-controller-labels

Conversation

@meneksece
Copy link
Copy Markdown

@meneksece meneksece commented May 11, 2026

How to categorize this PR?

What this PR does / why we need it:

This PR introduces structured ownership for Application Load Balancer (ALB) and Certificate resources. By using a consistent labeling system based on the IngressClass UID, the controller can now easily find and clean up the resources it created.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Key Changes:

  • Ownership Labeling: Introduced LabelIngressClassUID (prefixed with lb.customer.label/) to track resource provenance.

  • Label Merging Logic: Added logic in getAlbSpecForResources to merge user-defined labels, global config labels, and the internal ownership label (with a safety limit of 64 labels).

  • Extended Interface: Updated applyCertificates to accept the IngressClass object to ensure certificates are also labeled upon creation.

Breaking changes:

@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maboehm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2026
@meneksece meneksece changed the title added labels upon creation of alb and storing certificate Label-Based resource ownership - ALB and Certificates May 11, 2026
@meneksece meneksece force-pushed the feat/mc/add-alb-ingress-controller-labels branch from d1c0fba to 91b83ab Compare May 11, 2026 12:11
@ske-prow ske-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2026
@meneksece meneksece force-pushed the feat/kp/add-alb-ingress-controller branch from c7749a6 to 7af9e33 Compare May 11, 2026 12:22
@meneksece meneksece force-pushed the feat/mc/add-alb-ingress-controller-labels branch from 91b83ab to a14b123 Compare May 11, 2026 12:26
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 11, 2026

@meneksece: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-stackit-verify a14b123 link true /test pull-cloud-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant