Label-Based resource ownership - ALB and Certificates#1092
Label-Based resource ownership - ALB and Certificates#1092meneksece wants to merge 1 commit intofeat/kp/add-alb-ingress-controllerfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
d1c0fba to
91b83ab
Compare
c7749a6 to
7af9e33
Compare
91b83ab to
a14b123
Compare
|
@meneksece: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
How to categorize this PR?
What this PR does / why we need it:
This PR introduces structured ownership for Application Load Balancer (ALB) and Certificate resources. By using a consistent labeling system based on the IngressClass UID, the controller can now easily find and clean up the resources it created.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Key Changes:
Ownership Labeling: Introduced LabelIngressClassUID (prefixed with lb.customer.label/) to track resource provenance.
Label Merging Logic: Added logic in getAlbSpecForResources to merge user-defined labels, global config labels, and the internal ownership label (with a safety limit of 64 labels).
Extended Interface: Updated applyCertificates to accept the IngressClass object to ensure certificates are also labeled upon creation.
Breaking changes: