Skip to content

feat: re-implement @lexical/code-shiki to let Shiki load languages on-demand#2977

Draft
Soxasora wants to merge 2 commits into
stackernews:masterfrom
Soxasora:feat/lexical-shiki-lazyload-langs
Draft

feat: re-implement @lexical/code-shiki to let Shiki load languages on-demand#2977
Soxasora wants to merge 2 commits into
stackernews:masterfrom
Soxasora:feat/lexical-shiki-lazyload-langs

Conversation

@Soxasora
Copy link
Copy Markdown
Member

Description

Fixes #2976 by re-implementing @lexical/code-shiki allowing Shiki's default on-demand languages behavior.

This PR just demonstrates Lexical's build configuration bug, we should probably wait for a new, should be imminent, Lexical release that addresses this bug.

Screenshots

Before

image

After re-implementing code-shiki:

image

Additional Context

Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?

Checklist

Are your changes backward compatible? Please answer below:

For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

Did you use AI for this? If so, how much did it assist you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lexical code highlighting takes half of the main bundle size

1 participant