-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add FQDNs to the subject DNs of TLS certificates #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8187551
feat: Add FQDNs to the subject DNs of TLS certificates
siegfriedweber 2db9ecf
tests: Use specific operator versions in the tests
siegfriedweber cd88dce
Merge branch 'main' into feat/improve-tls-subject-dn
siegfriedweber ff41ee2
test(opa): Improve subject DN check
siegfriedweber 5343bd7
doc: Document OPA rego rules
siegfriedweber b39fbc8
Upgrade dependency "built" to fix cargo deny error
siegfriedweber f84bd11
Merge branch 'main' into feat/improve-tls-subject-dn
siegfriedweber 2ac18df
chore: Regenerate charts
siegfriedweber a68d9ca
test(smoke): Fix assertion
siegfriedweber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| apiVersion: zookeeper.stackable.tech/v1alpha1 | ||
| kind: ZookeeperCluster | ||
| metadata: | ||
| name: simple-zk | ||
| spec: | ||
| image: | ||
| productVersion: 3.9.5 | ||
| servers: | ||
| roleGroups: | ||
| default: | ||
| replicas: 1 | ||
| --- | ||
| apiVersion: zookeeper.stackable.tech/v1alpha1 | ||
| kind: ZookeeperZnode | ||
| metadata: | ||
| name: simple-kafka-znode | ||
| spec: | ||
| clusterRef: | ||
| name: simple-zk |
63 changes: 63 additions & 0 deletions
63
docs/modules/kafka/examples/security/02-authorization-opa.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| --- | ||
| apiVersion: opa.stackable.tech/v1alpha1 | ||
| kind: OpaCluster | ||
| metadata: | ||
| name: simple-opa | ||
| spec: | ||
| image: | ||
| productVersion: 1.16.2 | ||
| servers: | ||
| config: | ||
| logging: | ||
| containers: | ||
| opa: | ||
| loggers: | ||
| decision: | ||
| level: INFO | ||
| roleGroups: | ||
| default: {} | ||
| --- | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: kafka-rego-rules | ||
| labels: | ||
| opa.stackable.tech/bundle: "true" | ||
| data: | ||
| kafka.rego: | | ||
| package kafka | ||
|
|
||
| is_internal_request if input.requestContext.listenerName == "INTERNAL" | ||
| is_external_request if not is_internal_request | ||
|
|
||
| # FQDNs of the brokers as regular expressions | ||
| brokers_fqdn := [ | ||
| `local`, # cluster domain | ||
| `cluster`, # cluster domain | ||
| `svc`, | ||
| `default`, # namespace | ||
| `simple-kafka-broker-default-headless`, # Pod subdomain | ||
| `simple-kafka-broker-default-[0-9]+`, # Pod name | ||
| ] | ||
|
|
||
| domain_components = [concat("", [`DC=`, dc]) | some dc in brokers_fqdn] | ||
| common_name = `CN=generated certificate for pod` | ||
| subject_dn_fields = array.concat(domain_components, [common_name]) | ||
| brokers_subject_dn_pattern := concat("", ["^", concat(",", subject_dn_fields), "$"]) | ||
|
|
||
| default allow := false | ||
|
|
||
| allow if { | ||
| is_internal_request | ||
|
|
||
| regex.match( | ||
| brokers_subject_dn_pattern, | ||
| input.requestContext.principal.name, | ||
| ) | ||
| } | ||
|
|
||
| allow if { | ||
| is_external_request | ||
|
|
||
| # TODO Add your own rules | ||
| } |
18 changes: 18 additions & 0 deletions
18
docs/modules/kafka/examples/security/03a-authorization-kafkacluster.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| apiVersion: kafka.stackable.tech/v1alpha1 | ||
| kind: KafkaCluster | ||
| metadata: | ||
| name: simple-kafka | ||
| spec: | ||
| image: | ||
| productVersion: 3.9.2 | ||
| clusterConfig: | ||
| authorization: | ||
| opa: | ||
| configMapName: simple-opa | ||
| package: kafka | ||
| zookeeperConfigMapName: simple-kafka-znode | ||
| brokers: | ||
| roleGroups: | ||
| default: | ||
| replicas: 1 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.