Skip to content

feat: Add Monaco editor and simple Trino client - #18

Merged
labrenbe merged 26 commits into
mainfrom
feat/simple-trino-client
Mar 3, 2026
Merged

feat: Add Monaco editor and simple Trino client#18
labrenbe merged 26 commits into
mainfrom
feat/simple-trino-client

Conversation

@labrenbe

@labrenbe labrenbe commented Feb 23, 2026

Copy link
Copy Markdown
Member

Add a new page to query trino. Contains

  • Section for Trino connection config
  • Monaco editor to write SQL queries
  • Section to display paginated results

Features:

  • Current SQL query and connection config is saved in localStorage to persist through page reloads
  • Backend caches result from Trino in memory for pagination
  • Supports no auth and Basic auth on Trino
  • Added a Playwright test with a mocked Trino instance

Disclaimer: Aided by Claude

@labrenbe labrenbe self-assigned this Feb 23, 2026
lfrancke
lfrancke requested changes Feb 24, 2026
View reviewed changes
Comment thread e2e/trino.spec.ts Outdated
Comment thread src/lib/components/editor/MonacoEditor.svelte Outdated
Comment thread src/routes/(app)/trino/+page.svelte
Comment thread src/routes/(app)/trino/+page.svelte Outdated
Comment thread src/routes/(app)/trino/+page.svelte Outdated
Comment thread src/routes/api/trino/query/+server.ts Outdated
Comment thread src/routes/api/trino/query/+server.ts Outdated
Comment thread src/routes/(app)/trino/+page.svelte Outdated
lfrancke
lfrancke requested changes Feb 27, 2026
View reviewed changes

@lfrancke lfrancke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few accessibility issues but I think that's okay for now until we have the more final UI.

Comment thread src/routes/(app)/trino/+page.svelte Outdated
Comment thread src/routes/(app)/trino/+page.svelte Outdated
@labrenbe labrenbe mentioned this pull request Mar 2, 2026
Merged
@labrenbe @lfrancke
Update src/routes/(app)/trino/+page.svelte
a456dca 
Co-authored-by: Lars Francke <lars.francke@stackable.tech>
dervoeti
dervoeti reviewed Mar 3, 2026
View reviewed changes
Comment thread src/routes/(app)/trino/+page.server.ts
Comment thread AGENTS.md Outdated
labrenbe and others added 2 commits March 3, 2026 15:23
dervoeti
dervoeti previously approved these changes Mar 3, 2026
View reviewed changes
@labrenbe
labrenbe dismissed dervoeti’s stale review March 3, 2026 15:33

The merge-base changed after approval.

@labrenbe
labrenbe requested review from lfrancke and removed request for lfrancke March 3, 2026 15:36
@labrenbe
labrenbe merged commit e3fbe0b into main Mar 3, 2026
8 checks passed
@labrenbe
labrenbe deleted the feat/simple-trino-client branch March 3, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfrancke lfrancke lfrancke approved these changes
@dervoeti dervoeti dervoeti approved these changes

Assignees

@labrenbe labrenbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labrenbe @lfrancke @dervoeti