Repository navigation
feat(suite): add suite endpoints and internal service - #250
Conversation
58928bb to
7704285
Compare
7704285 to
d8ecec7
Compare
|
@BobAnkh This branch is ready to be merged into dev, and after the merge we can work on extracting executor to its separate module and prepare for updating the coordinator to allow executor to report suite tasks and hooks. |
d8ecec7 to
74f7d6a
Compare
BobAnkh
left a comment
There was a problem hiding this comment.
Please reformat all the documents; do not break them into such short sentences on each line, it is hard to read actually. It is not the old days. Please break the line at somewhere it should as much as possible, still do not make each line too long or too short. It is better for each line to carry part of the logic and you dont have to search for something next line to understand what this line means. Also please read all your documents. Some of them are really not what we will write in documents. If you want to explain something, you should explain clearly and human-readable. Do not use it as annotation.
I didn't comment on all documents I think is not good, so please check all of them again.
I will review again later for the service/suite and service/task (after you update documents). Others are really good.
Stacked on #247.
Filter tasks and artifacts by suite
suite_uuidon task query/cancel and artifact download/delete by-filter requests, with a--suiteCLI flag.group_nameand must match a given one. A suite the caller can't see, one that doesn't exist, and one that contradictsgroup_nameall return the same 404.suite_uuid.Change suite properties
PUT /suites/{uuid}andsuites change: name, description, tags, labels, priority, worker schedule, and per-hook changes (set / clear / leave alone). The hooks are merged in SQL inside a singleUPDATE.Cancelledsuites can't be changed.suites creategains--provision/--cleanup/--background.Suite counters and lock order on cancel and close
task_suite_idwas never set on submit, nor kept in the batch-cancel archive, so suite tasks weren't linked to their suite.incomplete_tasksgoes down on every cancel path and when a worker archives a task. AClosedsuite completes when it reaches zero.state <> Cancelled, which replaces the read-modify-write.UPDATE. Cancel marks the suite cancelled before archiving its tasks (so a racing submit can't land in it), archives through a CTE, and includesCancelledrows.service/mod.rs).report_taskno longer checksgroup_nameitself.