balar: shared packet wire ABI + coherence-aware DoorbellTestCPU and contract tests#2690
Open
nab880 wants to merge 11 commits into
Open
balar: shared packet wire ABI + coherence-aware DoorbellTestCPU and contract tests#2690nab880 wants to merge 11 commits into
nab880 wants to merge 11 commits into
Conversation
Add balar_test_topology.py (merlin router + coherent Bus for Doorbell P3) Add contract SDL tests: doorbell, malloc_free, coherent_bus, wide_packet
Introduces a Doorbell-pattern test CPU that mirrors Doorbell's dual-interface behavior without modifying BalarTestCPU, balarMMIO, or dmaEngine:
…ader Centralize BalarCudaCallPacket_t in balar_packet_wire.h for host and firmware.
Stream compact MMIO returns for sysmode so QEMU can receive malloc handles and D2H data directly.
DoorbellTestCPU read the enable_memcpy_dump parameter but never used it. Dump the GPU sim (and reference) D2H...
… wire-ABI size asserts Free the D2H simulator buffer (kept alive only via a balar-owned copy for validation); skip blank trace lines and fatal on unrecognized ones; use int64 for integer kernel args; free per-memcpy parser buffers; assert fallback CUDA struct sizes.
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements to start: Total Wait = 303
|
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2
Build InformationTest Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements
Using Repos:
Pull Request Author: nab880 |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 8 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Job: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements
Job: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist
Job: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2
Job: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2
Job: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements
|
balar_packet.h now includes balar_packet_wire.h, so the test harness must symlink the wire header alongside balar_packet.h/balar_consts.h.
Contributor
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
Contributor
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2
Build InformationTest Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements
Using Repos:
Pull Request Author: nab880 |
Contributor
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2
Build InformationTest Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2
Build InformationTest Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements
|
Contributor
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
4 similar comments
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Contributor
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing balar_packet.h pulls in the CUDA toolkit headers (builtin_types.h, driver_types.h) and wraps everything in SST C++ namespaces. That makes the byte layout impossible to share with any peer that isn't a full SST/CUDA C++ translation unit — there was no safe, dependency-light way for another driver to agree on exactly what bytes balar expects.
This PR factors the on-the-wire definitions out of balar_packet.h into a new standalone header, balar_packet_wire.
Contributions: