Added the MemEvent Id to the CacheListenerNotification in the CacheListener from MemHierarchy by EweLo · Pull Request #2622 · sstsimulator/sst-elements

EweLo · 2026-01-16T14:52:00Z

This PR extends the CacheListenerNotification interface to include the ID of the MemEvent that triggered the listener callback, enabling custom CacheListener implementations to trace the corresponding MemEvents.

I implemented this because I'm working on a complex tracer in SST that tracks memory access patterns and I therefore need to be able to correlate CacheListener notifications with specific memory events.

Added eventId field and getEventID() getter to CacheListenerNotification
Updated all notifyAccess() calls across MemHierarchy components to pass the event ID

sst-autotester · 2026-01-16T15:18:45Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

sst-autotester · 2026-01-28T09:48:57Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

EweLo · 2026-01-28T13:35:22Z

@gvoskuilen would you be willing to review this? :)

gvoskuilen

This change is sounds OK in general but I'd ask for two changes: (1) use SST::Event::id_type and SST::Event::NO_ID as the type is defined in that class, not memHierarchy and (2) ensure that event_id is not a required field since this interface is used by non-memHierarchy libraries and requiring it will break them.

gvoskuilen · 2026-02-20T15:32:11Z

    /* Listener callbacks */
    virtual void notifyListenerOfAccess(MemEvent * event, NotifyAccessType access_type, NotifyResultType result_type);
-    virtual void notifyListenerOfEvict(Addr addr, uint32_t size, uint64_t ip);
+    virtual void notifyListenerOfEvict(Addr addr, uint32_t size, Addr ip, MemEventBase::id_type evId);


id_type is actually defined in the SST::Event class. Can you update the references to it to point to that class instead?

gvoskuilen · 2026-02-20T15:32:43Z

                        mshr_->insertWriteback(tag->getAddr(), false);
                    recordPrefetchResult(tag, stat_prefetch_evict_);
-                    notifyListenerOfEvict(data->getAddr(), line_size_, 0);
+                    notifyListenerOfEvict(data->getAddr(), line_size_, 0, MemEventBase::NO_ID);


Should be SST::Event::NO_ID

gvoskuilen · 2026-02-20T15:33:00Z

                        mshr_->insertWriteback(tag->getAddr(), false);
                    recordPrefetchResult(tag, stat_prefetch_evict_);
-                    notifyListenerOfEvict(data->getAddr(), line_size_, 0);
+                    notifyListenerOfEvict(data->getAddr(), line_size_, 0, MemEventBase::NO_ID);


SST::Event::NO_ID

gvoskuilen · 2026-02-20T15:33:07Z

                        mshr_->insertWriteback(tag->getAddr(), false);
                    recordPrefetchResult(tag, stat_prefetch_evict_);
-                    notifyListenerOfEvict(data->getAddr(), line_size_, 0);
+                    notifyListenerOfEvict(data->getAddr(), line_size_, 0, MemEventBase::NO_ID);


SST::Event::NO_ID

gvoskuilen · 2026-02-20T15:33:29Z

                              NotifyAccessType accessT,
-                              NotifyResultType resultT) :
+                              NotifyResultType resultT,
+                              const MemEventBase::id_type evId) :


Can you also ensure there is still a constructor that doesn't require the id_type field/give id a default value? Other non-memHierarchy libraries use this interface and will break otherwise.

Also change MemEventBase::id_type to SST::Event::id_type

gvoskuilen · 2026-02-20T15:33:45Z

    NotifyAccessType getAccessType() const { return access; }
    NotifyResultType getResultType() const { return result; }
    uint32_t getSize() const { return size; }
+    MemEventBase::id_type getEventID() const { return eventId; }


SST::Event::id_type

gvoskuilen · 2026-02-20T15:34:14Z

    Addr instPtr;
    NotifyAccessType access;
    NotifyResultType result;
+    MemEventBase::id_type eventId;


SST::Event::id_type and give it a default value of SST::Event::NO_ID

ivlub · 2026-05-10T14:38:11Z

Hi @EweLo , thanks for this PR! I actually really need this feature for my thesis at CAPS now.
Are you still planning to update this? If you are busy, would you mind if I took your commits, applied the requested fixes, and opened a new PR crediting you? Please let me know:)

sst-autotester · 2026-05-11T13:49:07Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

…stener from MemHierarchy

… deprecated (old) constructor

sst-autotester · 2026-06-23T11:48:07Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

EweLo · 2026-06-23T12:29:21Z

@gvoskuilen I applied your suggested changes. Would you mind having a look at this again? :)

gvoskuilen self-requested a review February 17, 2026 19:49

gvoskuilen added Enhancement SST-memHierarchy labels Feb 17, 2026

gvoskuilen reviewed Feb 20, 2026

View reviewed changes

ivlub mentioned this pull request Jun 3, 2026

feat: prefetch hit detection via cache listener caps-tum/sst-mpi-buffer-tracer#2

Open

EweLo added 5 commits June 23, 2026 13:24

Added the MemEvent Id to the CacheListenerNotification in the CacheLi…

c34ec33

…stener from MemHierarchy

Removed default empty id

10d5b9d

added empty Event Id

b2c6ba4

Use MemEventBase::NO_ID for empty id

9d0c917

Update CacheListener to use SST::Event::id_type for event IDs and add…

21e37e0

… deprecated (old) constructor

EweLo force-pushed the add-memid-to-cachelistener branch from 69a5d22 to 21e37e0 Compare June 23, 2026 11:24

Update notifyListenerOfEvict to use SST::Event::id_type for event IDs

c6cb3b3

Uh oh!

Conversation

EweLo commented Jan 16, 2026

Uh oh!

sst-autotester commented Jan 16, 2026

Uh oh!

sst-autotester commented Jan 28, 2026

Uh oh!

EweLo commented Jan 28, 2026

Uh oh!

gvoskuilen left a comment

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gvoskuilen Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

ivlub commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sst-autotester commented May 11, 2026

Uh oh!

sst-autotester commented Jun 23, 2026

Uh oh!

EweLo commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ivlub commented May 10, 2026 •

edited

Loading