Lastools error handling#415
Merged
Merged
Conversation
Updated CI configuration to use latest versions of actions and environments.
58e39a7 to
2f29761
Compare
Member
Author
|
The error is now: @han16nah How should we handle this? Should AFWizard switch into demo mode if no license was found? |
Collaborator
Okay, seems like Linux and Windows behave differently here (Windows seems to automatically switch to So yes, it should then switch in demo mode. Maybe like: if result.returncode != 0 and not "Please note that LAStools is not" in result.stdout.decode():
raise AFwizardError(f"LASTools error: {result.stdout.decode()}")
elif result.returncode != 0:
logger.warning(f"LASTools warning: {result.stdout.decode()}")
# no license found, switching to demo mode
args.extend(["-demo"])
with within_temporary_workspace():
logger.info(
f"Executing LASTools command line '{' '.join(executable + args)}'"
)
result = subprocess.run(
executable + args,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
)I don't know if there is a more elegant way to catch the specific LAStools error.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.