FT: [FortiGate] Support pass-through management#467
Open
KarelChanivecky wants to merge 6 commits into
Open
Conversation
- Improve CLI state detection. Regex patterns were checked against source code ensuring compatibility from 7.0 and accross similar product families such as FortiProxy. - Refactor bootstrap_spin into a table-based FSM. - Add command queue mechanism. - Handle credential change request. - Handle hostname update. - Add exits on error. - Add state logging to help with debugging. - All terminal output is logged. Not just unmatched output. - Handle missing VM image. - Better error message when fail to launch due to not meeting password policy Tested on: - FGT 8.0.0:0167 GA (Debug) - FGT 7.6.6:3652 GA (Debug) - FGT 7.4.12:2902 GA - FGT 7.0.19:0696 GA - FGT 6.4.16:2098 GA - FPX 7.6.6:1628 GA - FPX 7.4.13:0722 GA (Debug) - FPX 7.2.16:0465 GA - FPX 7.0.23:0222 GA
Non admin user terminal prompts are terminated with $ instead of #. Also, the build label in the prompt is limited to STS or Interim values.
Basic support is added by reading from the standard config file location and writing to terminal. Added minimal config nesting detection to prevent the VM from hanging waiting for config scope exit.
Added support for static IP by configuring the VM management interface to use the configured IP of the container. Pass-through is now set as the default mode. This choice was made as the behavior is more intuitive. The host-forwarded mode needs more configuration to get proper default routes working. Updated the README for fortigate Added Fortinet/FortiGate to the list of NOS that set pass-through as default
f204316 to
d733363
Compare
This resolves routing table conflicts with in case the lab needs default routing.
d733363 to
dab9933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To support pass-through management interface
This PR is chained to #465
Fixes #466
Details
Set the correct static IP in the management interface (port1) when pass-through without DHCP is configured.
This mode is selected as default as it provides an easier way to have the default route be used for the actual lab work.
Additionally, update READMEs.
Testing
In a lab with topology such as:
FGT -> Router -> Server
Where the router is the default route for both the FGT and the Server
TEST: ssh into FGT
EXPECTED: FGT is reached. SSH connection completes
RESULT: As expected
TEST: ping Server from FGT
EXPECTED: Server is reached
RESULT: As expected
TEST: Ping FGT from server
EXPECTED: FGT is reached
RESULT: As expected