Expect eth0 interface to be set as num_provisioned_nics#166
Draft
hellt wants to merge 2 commits into
Draft
Conversation
|
Worth to mention that some kinds (IOSv/IOL/JunOS for example) have interface name checking that prevent specifying their names in a clab file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We always assumed eth0 is implicitly added by the container runtime.
This is not the case with network-mode:none where users add the eth0 interface manually.
The accompanying change is added to containerlab srl-labs/containerlab#1864 to count the management interface in CLAB_INTFS env var.