Repository navigation
CicsTask.within: primitive-table and cross-width numeric values of the LINKed DTO (X39, Part of #5060) - #5381
Merged
Merged
Conversation
…values count as the LINKed DTO's values (X39, Part of #5060) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
squid-protocol
added
the
shepherd:merge
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 17, 2026 22:22
Owner
Author
|
No description provided. |
squid-protocol
enabled auto-merge (squash)
October 17, 2026 22:24
Contributor
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5060 (first checkbox: model-port scalar fields; the base was shipped in #5332, this closes its remaining holes).
Class: XCTL of storage a LINK caller owns (X39), model-port path: a value COMMAREA is traced by equality, so every way a DTO holds a value must be compared the same way.
Change (template-only,
CICS_TASK_JAVA):withinnow (1) walks primitive arrays (int[],char[]tables) for a value part, (2) compares numbers by numeric value whatever width or scale (sameValue: int vs long, 1.5 vs 1.50). Equal-valued copies stay over-refused (refuse, never guess).Tests:
test_model_link_xctl_4956.pyadds table int/char element, widened/narrowed long/int, BigDecimal scale, boolean (refused) and a distinct char / distinct number (not refused). Ran with the 4816/4957 XCTL tests andtests/cics_crucible/test_cics_runtimes.py: 222 passed, 3 skipped.pr_gates --fast: 6/6.det_port check: every port's generated
CicsTask.javachanges by 25 template lines (runtime text only; no port uses a LINKed DTO XCTL path differently). Re-prove list not run (120 ports).Not run: golden bless (no parsing-logic change).
Sibling gaps: copy vs same storage needs a real z/OS run (stays REFUSED, not churn). No burned-estate program known to need these forms; not grepped.
Cross-repo: none.
Lessons for agents
det_port.py checkreports every port CHANGED for anyCICS_TASK_JAVAedit; it is template text, not behaviour.🤖 Generated with Claude Code