Repository navigation
port_invariance: regenerate fixture, function_count fixture floor 0.80 -> 0.70 (#4444) - #4673
Merged
Merged
Conversation
Contributor
Owner
Author
|
Owner decision (2026-10-08): do NOT lower the function_count floor. Keep 0.80 and fix the measurement instead: count only Java methods that correspond to COBOL paragraphs, excluding generated helpers (named 88-condition predicates from #4202, 🤖 Generated with Claude Code |
…back to 0.80 (#4444) The Java side counted every method, including helpers the translator generates (88-condition predicates, abended(), caWhole(), initialState()); only methods documented as a COBOL paragraph count now. 12-pair rho 0.778 -> 1.000. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MQNoe4wPJgr7dbUvs3DG6D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4444
Cause
The 12-pair fixture predates deliberate translator changes that add methods with no COBOL paragraph behind them: named 88-condition predicates (#4202),
abended()(#4541),caWhole()(#4642),initialState()(#4218). Counting every Java method moved the 12-pairfunction_countrho from 0.912 to 0.778 (CSUTLDTC: 22 methods against 3 paragraphs). No scanner reading regressed.Fix (owner decision: keep the floor, fix the measurement)
function_countfloor stays 0.80 (the 0.70 change is reverted intests/tools/port_invariance.pyanddocs/port_invariance_contract.md)./** PARAGRAPH-NAME. */(det/program.py); helpers carry a prose comment,/** 88 NAME of PARENT. */, or none. The scanner'sdocstringfor each method is matched againstPARAGRAPH_DOC, so no hand list of helper names. The COBOL side is unchanged.det_port.py run --all-cases --translate-onlythenport_invariance.py fixtureon current main + branch (merged origin/main).Result
12-pair
function_countrho: 0.778 before -> 1.000 after (floor 0.80). Every pair's paragraph-method count equals its COBOL paragraph count. The 49-pair figure was not re-measured.Tests
port_invariance.py check: contract holds (fn 1.000/0.80, branch 0.745/0.65, flux 0.796/0.55, io 0.958/0.80, ipc 0.757/0.60).test_port_invariance.py: 4 passed, 1 skipped (needs sweep).pr_gates.py --fast: 5/5;--ratchets(JDK 17 env): 7 pass, 0 fail.🤖 Generated with Claude Code
https://claude.ai/code/session_01MQNoe4wPJgr7dbUvs3DG6D