Relax cloudpickle constraint#59
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019e0093-6ff2-7089-9841-7274fbfae1f8 Co-authored-by: Amp <amp@ampcode.com>
AsherWright
approved these changes
May 7, 2026
Collaborator
AsherWright
left a comment
There was a problem hiding this comment.
Might be worth testing this to confirm cloudpickle3 works fine
jhamet93
approved these changes
May 7, 2026
Amp-Thread-ID: https://ampcode.com/threads/T-019e0093-6ff2-7089-9841-7274fbfae1f8 Co-authored-by: Amp <amp@ampcode.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
Author
@AsherWright yeah good call. I've validated locally that the entire API surface we're using with cloudpickle works in both 2 and 3. I've now updated the lockfile here so it's using 3 in the test suite (which covers some but all uses, covering all would require too many mocks, I dont think we should). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Prefect 3.6.28+ requires
cloudpickle>=3.1.1, but block-cascade's existing^2.0constraint prevents downstream projects from upgrading Prefect for SCC remediation.What
>=2.0,<4.03.2.1for a publishable patch releaseRisk Assessment
Low — this is a dependency metadata change only, and focused executor tests pass with the resolved dependency set.
References
poetry checkpoetry run pytest tests/test_local_executor.py tests/test_vertex_executor.py -qUpdate May 8, 09:20: Locked and tested cloudpickle 3.1.2.
poetry.lockto resolvecloudpickle==3.1.2poetry run pytest tests/test_local_executor.py tests/test_vertex_executor.py tests/test_databricks_executor.py tests/executors/databricks/resource/test_python_library.py -qpoetry sync --without torch:poetry run pytest -q(46 passed, 1 skipped)