Creates Invoice Settings Controller with views#53
Open
Bartuz wants to merge 5 commits into
Open
Conversation
added 5 commits
June 4, 2014 11:52
Now if URL is given (like "http://github.com/images/logo.png") prawn will download this file and use it in invoice.
It has its own controller and section in navigation in admin configuration tab. It will help a lot in future changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings are no more ing eneral settings. Also I made easier to add logo (You can do it in admin panel). What is more I changed few things about footer_left/right_1/2 - you can setup them in admin panel and its render properly.
These changes make developing this extension a bit easier (it has its own views and controller)
This is invoices settings controller views:
This is how new footer is being rendered: