Do not set @client_secret and @pk_key if order has no valid payments#405
Open
AlexeyBoldak wants to merge 1 commit into
Open
Do not set @client_secret and @pk_key if order has no valid payments#405AlexeyBoldak wants to merge 1 commit into
AlexeyBoldak wants to merge 1 commit into
Conversation
AlexeyBoldak
force-pushed
the
fix/properly-handle-order-payments
branch
from
6fc98ae to
938b504
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue happened with this type of cards
The cards in the previous table can’t be attached to a Customer object. To simulate a declined payment with a successfully attached card, use the next one.
4000000000000341After successfully attaching the card inside CheckoutControllerDecorator#process_payments_and_set_keys we call
order.process_payments!, we mark this card (payment method) as invalid. And this behaviour leads to errorNoMethodError, undefined methodintent_client_key' for nil:NilClass`I believe that this fix relates to this issue #379