Skip to content

update gemfile#400

Open
KacperMekarski wants to merge 5 commits into
mainfrom
update-gemfile
Open

update gemfile#400
KacperMekarski wants to merge 5 commits into
mainfrom
update-gemfile

Conversation

@KacperMekarski

Copy link
Copy Markdown
Contributor

No description provided.

end

def payment_source_class
Check

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to lack of CheckSerializer error:
NameError: Spree::Api::V2::Platform::PaymentSerializer cannot resolve a serializer class for 'Spree::Check'. Attempted to find 'Spree::Api::V2::Platform::CheckSerializer'. Consider specifying the serializer directly through options[:serializer]. I found out that in this case nil should be returned and source shouldn't be required:
https://github.com/spree/spree/blob/main/core/app/models/spree/payment_method.rb#L34

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KacperMekarski we cannot change this to nil, we need to add that serializer

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

end

def payment_source_class
Check

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KacperMekarski we cannot change this to nil, we need to add that serializer

@gjoc96 gjoc96 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Case has been resolved.

@gjoc96

gjoc96 commented Dec 17, 2021

Copy link
Copy Markdown

No major conflict has been found in data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants