This repository was archived by the owner on Mar 21, 2025. It is now read-only.
product packages have priority over dimensions#161
Open
mrpollo wants to merge 1 commit into
Open
Conversation
this is required so we don't send and extra package previously it would create a package with the default variant attributes and append it to the product packages
Contributor
Author
|
don't merge this yet I need to redo some of the tests... I'm also feeling that the whole weight array poop that is going on should be gone from here since we have the splitters on spree_core doing that job already ( splitting packages per weight )... would love input here... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is required so we don't send and extra package previously it would create a package with the default variant attributes and append it to the product packages, this would create in some cases expansive rate results
in some cases: carriers typically would measure the package and pick either the dimensions or the weight (whichever is more expensive) and use that to calculate the rates