Skip to content

Deprecation fix: to saved_changes?#175

Open
joshRpowell wants to merge 2 commits into
spree-contrib:masterfrom
milner-group:deprecation/fix
Open

Deprecation fix: to saved_changes?#175
joshRpowell wants to merge 2 commits into
spree-contrib:masterfrom
milner-group:deprecation/fix

Conversation

@joshRpowell

Copy link
Copy Markdown

Resolves:

DEPRECATION WARNING: The behavior of `changed?` inside of after callbacks will be changing in the next version of Rails. The new return value will ref
lect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved
_changes?` instead. (called from update_inventory at /Users/jpowell/.gem/ruby/2.4.4/bundler/gems/spree-product-assembly-92ad5f4342a7/app/models/spree/
line_item_decorator.rb:43)

@joshRpowell

joshRpowell commented Apr 23, 2018

Copy link
Copy Markdown
Author

CI fails on all Spree 3.2 which supports Rails 5.0. Green for Spree >= 3.3

Perhaps its worth versioning this Gem?

@joshRpowell joshRpowell closed this Sep 4, 2018
@joshRpowell joshRpowell reopened this Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant