Skip to content

Clean up stale flag 'test-flag' #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
confidence-bot wants to merge 1 commit into from
Closed

Clean up stale flag 'test-flag' #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/sdk/src/FlagResolution.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ function makeResponse(overrides: Partial<Parameters<typeof makeResolvedFlag>[0]>
}

function makeResolvedFlag({
flag = 'flags/test-flag',
variant = 'flags/test-flag/variants/treatment',
flag = 'flags/mock-flag',
variant = 'flags/mock-flag/variants/treatment',
value = { my_bool: true, my_string: 'hello' } as { [key: string]: any } | undefined,
reason = ResolveReason.RESOLVE_REASON_MATCH,
shouldApply = true,
Expand All @@ -35,16 +35,16 @@ describe('FlagResolution', () => {
const response = makeResponse();
const resolution = FlagResolution.ready({}, response);

resolution.evaluate('test-flag.my_bool', false);
resolution.evaluate('mock-flag.my_bool', false);

expect(publishFlagEvaluation).toHaveBeenCalledWith('flags/test-flag', 'flags/test-flag/variants/treatment');
expect(publishFlagEvaluation).toHaveBeenCalledWith('flags/mock-flag', 'flags/mock-flag/variants/treatment');
});

it('does not publish on NO_SEGMENT_MATCH', () => {
const response = makeResponse({ reason: ResolveReason.RESOLVE_REASON_NO_SEGMENT_MATCH });
const resolution = FlagResolution.ready({}, response);

resolution.evaluate('test-flag.my_bool', false);
resolution.evaluate('mock-flag.my_bool', false);

expect(publishFlagEvaluation).not.toHaveBeenCalled();
});
Expand All @@ -66,7 +66,7 @@ describe('FlagResolution', () => {
});
const resolution = FlagResolution.ready({}, response);

const result = resolution.evaluate('test-flag.my_string', 'fallback');
const result = resolution.evaluate('mock-flag.my_string', 'fallback');

expect(result.reason).toBe('MATCH');
expect(result.value).toBe('fallback');
Expand All @@ -78,7 +78,7 @@ describe('FlagResolution', () => {
});
const resolution = FlagResolution.ready({}, response);

const result = resolution.evaluate('test-flag.my_string', 'fallback');
const result = resolution.evaluate('mock-flag.my_string', 'fallback');

expect(result.reason).toBe('MATCH');
expect(result.value).toBe('hello');
Expand All @@ -90,7 +90,7 @@ describe('FlagResolution', () => {
});
const resolution = FlagResolution.ready({}, response);

const result = resolution.evaluate('test-flag.my_bool', false);
const result = resolution.evaluate('mock-flag.my_bool', false);

expect(result.reason).toBe('MATCH');
expect(result.value).toBe(false);
Expand Down
Loading