feat: add URL flag type with net/url support#494
Closed
happysnaker wants to merge 1 commit into
Closed
Conversation
Adds a native URL flag type backed by url.URL from the standard library. Includes URLVar, URLVarP, URL, URLP methods on FlagSet and corresponding package-level functions. Fixes spf13#398
Author
|
Closing due to Go 1.12 test failure — URL type requires more work for backward compatibility. Will re-approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398
Adds a native URL flag type backed by
url.URLfrom the standard library. Users can now define URL flags that automatically validate and parse URL values.API
Example