Skip to content

Security: Insecure Temporary File Creation with Predictable Path #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Security: Insecure Temporary File Creation with Predictable Path #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/defaultcodesamples/defaultcodesamples.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ func DefaultCodeSamples(ctx context.Context, flags DefaultCodeSamplesFlags) erro
if err != nil {
return fmt.Errorf("failed to read default code samples file: %w", err)
}
tempDir := os.TempDir()
tempDir, err := os.MkdirTemp("", "defaultcodesamples-*")
if err != nil {
return fmt.Errorf("failed to create temporary directory: %w", err)
}
defer os.RemoveAll(tempDir)
tempFile := fmt.Sprintf("%s/defaultcodesamples.js", tempDir)
err = os.WriteFile(tempFile, result, 0o644)
if err != nil {
Expand Down
Loading