Change style options and a new setting for intializing#50
Conversation
Move javascript inline CSS into CSS file Add marker.style option Add directInitialize setting
spchuang
left a comment
There was a problem hiding this comment.
All the changes look reasonable to me except moving/addition of markerStyle.
| video.markers({ | ||
| markerStyle: { | ||
| 'width':'8px', | ||
| 'background-color': 'red' |
There was a problem hiding this comment.
I'm inclined to not make this change since it is a big breaking change to the API. Moving markerStyle to markerTip.style isn't appropriate either because markerTip is used for the hover-over pointer thing.
|
@nyroDev sorry for the late reply. Just took a look and commented at the code change. |
| markers: [ | ||
| {time: 9.5, text: "this"}, | ||
| {time: 16, text: "is"}, | ||
| {time: 16, text: "is", style: {'background-color': 'yellow'}}, |
There was a problem hiding this comment.
Just took another look. Currently, we offer the ability to append class to marker object like {time: 9.5, text: "this", overlayText: "1", class: "special-blue"}, which achieves the same thing as passing a style object.
Is there a scenario where you can't pass in a class name and need hardcoded style?
I updated the doc as far as I can see, but some elements still need to be done:
Hope this will help.