Add shipmonk/dead-code-detector to PHPStan config#91
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR integrates ShipMonk’s dead-code-detector into the existing PHPStan setup and makes small supporting adjustments so the static analysis configuration runs cleanly in this repository.
Changes:
- Add
shipmonk/dead-code-detectoras a dev dependency and include its PHPStan ruleset. - Tighten a test phpdoc type to improve static analysis signal.
- Ignore GnuPG agent socket files created during signature-related tests.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
composer.json |
Adds shipmonk/dead-code-detector to require-dev to enable dead-code analysis tooling. |
phpstan.neon |
Includes dead-code-detector’s rules.neon so its rules run as part of composer phpstan. |
tests/SecurityTxtTest.phpt |
Updates phpdoc typing (and import) to better inform PHPStan about the $fieldClass parameter. |
.gitignore |
Ignores S.gpg-agent* artifacts produced under the gnupg test directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spaze
force-pushed
the
spaze/dead-code-detector
branch
from
April 11, 2026 15:00
c8be72f to
9fdc645
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix some problems so that it runs with no errors or warnings.
https://github.com/shipmonk-rnd/dead-code-detector
Close #87