Skip to content

Add IFC notebook#19

Open
drlaw1558 wants to merge 1 commit into
spacetelescope:developfrom
drlaw1558:ifc
Open

Add IFC notebook#19
drlaw1558 wants to merge 1 commit into
spacetelescope:developfrom
drlaw1558:ifc

Conversation

@drlaw1558

Copy link
Copy Markdown

IFC notebook calculation to reproduce one of the simulations in TR-1701 has been added. This relies upon data added in a new pull request to pandeia_data

@ariedel

ariedel commented Dec 19, 2018

Copy link
Copy Markdown
Collaborator

Compatibility note: We're planning to revert Pandeia to v1.2.2 to fix a bug that breaks the R062 WFI filter.

Because of changes to the way precomputed "canned" backgrounds are handled in v1.3, the v1.3 (and later, such as with your additions) data won't be compatible with the v1.2.2 code.

We should discuss if we need to cherry-pick and make a new data delivery, or just wait for a v1.4 release of Pandeia (tentatively scheduled for April)

@drlaw1558

Copy link
Copy Markdown
Author

My feeling is that the actual work of producing the notebook and linking to the associated pandeia_data products is done, so waiting for v1.4 to simply merge the branch would be ok. However, Karrie should weigh in.

@ariedel

ariedel commented May 29, 2019

Copy link
Copy Markdown
Collaborator

The IFC notebook should now work (possibly with some modifications for names) with Pandeia v1.4, which includes the IFU files.

Base automatically changed from master to develop January 25, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants