Skip to content

[WIP] Build Grating Wheel Sensor Telemetry Monitor#825

Open
tnking97 wants to merge 19 commits into
spacetelescope:developfrom
tnking97:gw_monitor
Open

[WIP] Build Grating Wheel Sensor Telemetry Monitor#825
tnking97 wants to merge 19 commits into
spacetelescope:developfrom
tnking97:gw_monitor

Conversation

@tnking97

Copy link
Copy Markdown
Contributor

No description provided.

@pep8speaks

pep8speaks commented Oct 14, 2021

Copy link
Copy Markdown

Hello @tnking97, Thank you for updating !

Line 27:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file
Line 30:1: E402 module level import not at top of file
Line 31:1: E402 module level import not at top of file
Line 32:1: E402 module level import not at top of file
Line 33:1: E402 module level import not at top of file
Line 34:1: E402 module level import not at top of file
Line 80:85: E712 comparison to True should be 'if cond is True:' or 'if cond:'

Line 369:21: E126 continuation line over-indented for hanging indent

Line 60:1: E402 module level import not at top of file
Line 69:1: E402 module level import not at top of file
Line 70:1: E402 module level import not at top of file
Line 363:41: E128 continuation line under-indented for visual indent
Line 914:13: E125 continuation line with same indent as next logical line
Line 915:17: E117 over-indented
Line 1169:9: E722 do not use bare 'except'
Line 1257:21: E128 continuation line under-indented for visual indent

Line 114:55: E711 comparison to None should be 'if cond is not None:'

Comment last updated at 2021-12-09 20:53:47 UTC

@tnking97 tnking97 linked an issue Oct 14, 2021 that may be closed by this pull request
9 tasks
@tnking97 tnking97 self-assigned this Oct 14, 2021
@bourque bourque self-requested a review December 9, 2021 18:50

@bourque bourque left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnking97 I just did an initial review of this and it looks really good! All of the major pieces are there. It is well organized, documented, and tested, and I don't see any major changes that need to be made. Excellent work!

Comment thread docs/source/common_monitors.rst
Comment thread jwql/website/apps/jwql/data_containers.py
Comment thread jwql/tests/test_grating_monitor.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Grating Wheel Sensor Telemetry Monitor

4 participants