Aliveness Test Script#1692
Open
york-stsci wants to merge 1 commit into
Open
Conversation
bhilbert4
approved these changes
Jul 24, 2025
bhilbert4
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. There are a couple hardcoded instances of the URLs in the repo that can be replaced with the new variables from constants.py
| URLS = { | ||
| "CRDS": "https://jwst-crds.stsci.edu", | ||
| "DATAMODEL_SCHEMA": "http://stsci.edu/schemas/jwst_datamodel/subarray.schema", | ||
| "STSCI_JWST_PHASE2": "https://www.stsci.edu/jwst/phase2-public", |
Collaborator
There was a problem hiding this comment.
Looks like this URL is used in data_containers.py. Would be good to switch that hardcoded URL to this entry from constants.py
| "CRDS": "https://jwst-crds.stsci.edu", | ||
| "DATAMODEL_SCHEMA": "http://stsci.edu/schemas/jwst_datamodel/subarray.schema", | ||
| "STSCI_JWST_PHASE2": "https://www.stsci.edu/jwst/phase2-public", | ||
| "STSCI_JWST_PROGRAM_INFO": "https://www.stsci.edu/jwst-program-info", |
Collaborator
There was a problem hiding this comment.
Looks like this URL is used in data_containers.py (line 2089). Would be good to switch that hardcoded URL to this entry from constants.py
| "DATAMODEL_SCHEMA": "http://stsci.edu/schemas/jwst_datamodel/subarray.schema", | ||
| "STSCI_JWST_PHASE2": "https://www.stsci.edu/jwst/phase2-public", | ||
| "STSCI_JWST_PROGRAM_INFO": "https://www.stsci.edu/jwst-program-info", | ||
| "STSCI_MAST": "https://mast.stsci.edu/", |
Collaborator
There was a problem hiding this comment.
Looks like this URL is used in utils.py (line 320) and in claw_monitor.py. Would be good to switch those hardcoded URLs to this entry from constants.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change