[WIP]: Add TA monitor for NIRCam, NIRISS, MIRI

[bhilbert4]

Add the TA monitor, with requirements specified by our meeting with the instrument teams and coronagraphy working group. The code is still under heavy development. At the moment the general layout for the non-coronagraphy TA monitor is nearly there. The coronagraphic TA monitor work will copy and extend the non-coronagraphic functionality.

Development on plot creation also has not started. Plots need to be made using straight Bokeh, rather than Bokeh templating, which has been effectively deprecated for a while.

This PR replaces #1278

[pep8speaks]

Hello @bhilbert4, Thank you for updating !

• In the file jwql/edb/engdb_oss_msgs.py:

Line 47:5: E303 too many blank lines (2)
Line 76:5: E303 too many blank lines (2)
Line 89:62: E203 whitespace before ':'
Line 90:17: E265 block comment should start with '# '
Line 109:45: E221 multiple spaces before operator
Line 125:65: E261 at least two spaces before inline comment
Line 129:5: E303 too many blank lines (2)
Line 140:33: E203 whitespace before ':'
Line 147:75: E231 missing whitespace after ','
Line 147:79: E231 missing whitespace after ','
Line 147:87: E231 missing whitespace after ','
Line 148:108: E231 missing whitespace after ','
Line 152:44: E231 missing whitespace after ','
Line 160:27: E225 missing whitespace around operator
Line 165:45: E221 multiple spaces before operator
Line 180:5: E303 too many blank lines (2)
Line 208:43: E203 whitespace before ':'
Line 212:44: E231 missing whitespace after ','
Line 218:44: E231 missing whitespace after ','
Line 224:44: E231 missing whitespace after ','
Line 230:44: E231 missing whitespace after ','
Line 238:44: E231 missing whitespace after ','
Line 250:27: E225 missing whitespace around operator
Line 255:45: E221 multiple spaces before operator
Line 267:65: E261 at least two spaces before inline comment
Line 270:1: E302 expected 2 blank lines, found 1
Line 288:12: E225 missing whitespace around operator

• In the file jwql/instrument_monitors/common_monitors/ta_monitor.py:

Line 46:1: E265 block comment should start with '# '
Line 47:1: E265 block comment should start with '# '
Line 59:26: E261 at least two spaces before inline comment
Line 63:26: E128 continuation line under-indented for visual indent
Line 64:26: E128 continuation line under-indented for visual indent
Line 65:1: E128 continuation line under-indented for visual indent
Line 66:2: E128 continuation line under-indented for visual indent
Line 67:2: E128 continuation line under-indented for visual indent
Line 68:2: E128 continuation line under-indented for visual indent
Line 69:2: E128 continuation line under-indented for visual indent
Line 70:2: E128 continuation line under-indented for visual indent
Line 71:2: E128 continuation line under-indented for visual indent
Line 116:1: E302 expected 2 blank lines, found 1
Line 131:46: E231 missing whitespace after ','
Line 134:106: E226 missing whitespace around arithmetic operator
Line 135:56: E226 missing whitespace around arithmetic operator
Line 138:85: E231 missing whitespace after ','
Line 139:9: E265 block comment should start with '# '
Line 148:1: E302 expected 2 blank lines, found 1
Line 166:23: E226 missing whitespace around arithmetic operator
Line 167:23: E226 missing whitespace around arithmetic operator
Line 169:33: E231 missing whitespace after ','
Line 169:45: E231 missing whitespace after ','
Line 170:48: E231 missing whitespace after ','
Line 172:57: E226 missing whitespace around arithmetic operator
Line 173:57: E226 missing whitespace around arithmetic operator
Line 174:56: E226 missing whitespace around arithmetic operator
Line 175:56: E226 missing whitespace around arithmetic operator
Line 181:46: E226 missing whitespace around arithmetic operator
Line 182:46: E226 missing whitespace around arithmetic operator
Line 183:31: E231 missing whitespace after ','
Line 185:47: E226 missing whitespace around arithmetic operator
Line 186:47: E226 missing whitespace around arithmetic operator
Line 189:42: E226 missing whitespace around arithmetic operator
Line 190:43: E226 missing whitespace around arithmetic operator
Line 191:42: E226 missing whitespace around arithmetic operator
Line 192:43: E226 missing whitespace around arithmetic operator
Line 193:21: E231 missing whitespace after ','
Line 196:9: E303 too many blank lines (2)
Line 197:47: E226 missing whitespace around arithmetic operator
Line 197:66: E226 missing whitespace around arithmetic operator
Line 197:68: E231 missing whitespace after ','
Line 197:93: E226 missing whitespace around arithmetic operator
Line 197:112: E226 missing whitespace around arithmetic operator
Line 200:9: E265 block comment should start with '# '
Line 230:9: E303 too many blank lines (3)
Line 237:9: E303 too many blank lines (5)
Line 238:66: E231 missing whitespace after ','
Line 240:9: E265 block comment should start with '# '
Line 252:35: E127 continuation line over-indented for visual indent
Line 253:35: E127 continuation line over-indented for visual indent
Line 263:9: E265 block comment should start with '# '
Line 271:9: E265 block comment should start with '# '
Line 297:62: E231 missing whitespace after ','
Line 298:60: E231 missing whitespace after ','
Line 430:1: E303 too many blank lines (4)
Line 526:5: E303 too many blank lines (2)
Line 542:5: E303 too many blank lines (2)
Line 546:22: E261 at least two spaces before inline comment
Line 546:22: E262 inline comment should start with '# '
Line 549:22: E265 block comment should start with '# '
Line 570:5: E303 too many blank lines (3)
Line 942:99: E261 at least two spaces before inline comment
Line 942:100: E262 inline comment should start with '# '
Line 950:56: E261 at least two spaces before inline comment
Line 950:57: E262 inline comment should start with '# '
Line 962:5: E303 too many blank lines (2)
Line 965:5: E265 block comment should start with '# '
Line 966:5: E265 block comment should start with '# '
Line 974:5: E303 too many blank lines (7)
Line 988:5: E303 too many blank lines (2)
Line 1001:5: E303 too many blank lines (2)
Line 1009:13: E265 block comment should start with '# '
Line 1010:13: E265 block comment should start with '# '
Line 1051:9: E265 block comment should start with '# '
Line 1059:9: E265 block comment should start with '# '
Line 1060:9: E265 block comment should start with '# '
Line 1061:9: E265 block comment should start with '# '
Line 1063:9: E265 block comment should start with '# '
Line 1064:9: E265 block comment should start with '# '
Line 1071:17: E265 block comment should start with '# '
Line 1074:13: E265 block comment should start with '# '
Line 1075:13: E265 block comment should start with '# '
Line 1078:28: E225 missing whitespace around operator
Line 1081:9: E303 too many blank lines (2)
Line 1083:13: E265 block comment should start with '# '
Line 1084:13: E265 block comment should start with '# '
Line 1085:13: E265 block comment should start with '# '
Line 1087:13: E265 block comment should start with '# '
Line 1126:9: E303 too many blank lines (2)
Line 1129:9: E303 too many blank lines (2)
Line 1135:9: E265 block comment should start with '# '
Line 1148:13: E303 too many blank lines (2)
Line 1156:13: E303 too many blank lines (3)
Line 1172:13: E303 too many blank lines (2)
Line 1177:5: E265 block comment should start with '# '
Line 1220:46: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1229:9: E265 block comment should start with '# '
Line 1230:10: E114 indentation is not a multiple of four (comment)
Line 1297:9: E303 too many blank lines (3)
Line 1331:9: E303 too many blank lines (2)
Line 1351:9: E303 too many blank lines (2)
Line 1352:9: E265 block comment should start with '# '
Line 1353:9: E265 block comment should start with '# '
Line 1357:9: E265 block comment should start with '# '
Line 1360:9: E265 block comment should start with '# '
Line 1363:9: E265 block comment should start with '# '
Line 1367:9: E303 too many blank lines (2)
Line 1372:9: E303 too many blank lines (2)
Line 1373:9: E265 block comment should start with '# '
Line 1381:9: E265 block comment should start with '# '
Line 1381:9: E303 too many blank lines (3)
Line 1384:9: E303 too many blank lines (2)
Line 1396:9: E303 too many blank lines (3)
Line 1448:9: E303 too many blank lines (3)
Line 1457:9: E265 block comment should start with '# '
Line 1458:9: E265 block comment should start with '# '
Line 1473:42: E127 continuation line over-indented for visual indent
Line 1473:42: W503 line break before binary operator
Line 1477:9: E265 block comment should start with '# '
Line 1478:9: E265 block comment should start with '# '
Line 1480:9: E265 block comment should start with '# '
Line 1515:9: E303 too many blank lines (3)
Line 1527:13: E265 block comment should start with '# '
Line 1535:13: E265 block comment should start with '# '
Line 1557:9: E303 too many blank lines (2)
Line 1577:13: E303 too many blank lines (2)
Line 1583:13: E303 too many blank lines (2)
Line 1592:9: E265 block comment should start with '# '
Line 1598:9: E303 too many blank lines (5)
Line 1624:9: E303 too many blank lines (4)
Line 1626:19: E222 multiple spaces after operator
Line 1626:49: E231 missing whitespace after ','
Line 1631:9: E265 block comment should start with '# '
Line 1649:13: E265 block comment should start with '# '
Line 1652:9: E722 do not use bare 'except'
Line 1677:58: E261 at least two spaces before inline comment
Line 1677:59: E262 inline comment should start with '# '
Line 1696:5: E303 too many blank lines (2)
Line 1722:9: E265 block comment should start with '# '
Line 1728:9: E303 too many blank lines (2)
Line 1736:9: E303 too many blank lines (3)
Line 1744:13: E303 too many blank lines (2)
Line 1757:13: E265 block comment should start with '# '
Line 1760:13: E265 block comment should start with '# '
Line 1761:13: E265 block comment should start with '# '
Line 1780:9: E265 block comment should start with '# '
Line 1783:9: E265 block comment should start with '# '
Line 1793:13: E265 block comment should start with '# '
Line 1794:13: E265 block comment should start with '# '
Line 1797:13: E265 block comment should start with '# '
Line 1798:13: E265 block comment should start with '# '
Line 1799:13: E265 block comment should start with '# '
Line 1805:13: E265 block comment should start with '# '
Line 1841:13: E265 block comment should start with '# '
Line 1844:13: E303 too many blank lines (2)
Line 1847:13: E303 too many blank lines (2)
Line 1849:13: E265 block comment should start with '# '
Line 1850:13: E265 block comment should start with '# '
Line 1853:13: E303 too many blank lines (2)
Line 1884:13: E303 too many blank lines (2)
Line 1890:13: E303 too many blank lines (3)
Line 1897:13: E303 too many blank lines (2)
Line 1902:13: E303 too many blank lines (4)
Line 1905:17: E303 too many blank lines (2)
Line 1922:21: E303 too many blank lines (2)
Line 1940:13: E303 too many blank lines (4)
Line 1949:13: E265 block comment should start with '# '
Line 1951:13: E265 block comment should start with '# '
Line 1952:13: E265 block comment should start with '# '
Line 1957:1: E303 too many blank lines (4)
Line 1988:1: E302 expected 2 blank lines, found 1
Line 2019:1: E303 too many blank lines (4)
Line 2027:18: W292 no newline at end of file

• In the file jwql/utils/constants.py:

Line 340:42: E241 multiple spaces after ':'
Line 341:42: E241 multiple spaces after ':'
Line 342:42: E241 multiple spaces after ':'
Line 343:42: E241 multiple spaces after ':'
Line 344:41: E241 multiple spaces after ':'
Line 345:42: E241 multiple spaces after ':'
Line 346:42: E241 multiple spaces after ':'
Line 347:42: E241 multiple spaces after ':'
Line 348:41: E241 multiple spaces after ':'
Line 349:41: E241 multiple spaces after ':'
Line 350:42: E241 multiple spaces after ':'
Line 351:41: E241 multiple spaces after ':'
Line 352:42: E241 multiple spaces after ':'
Line 353:42: E241 multiple spaces after ':'
Line 354:42: E241 multiple spaces after ':'
Line 356:42: E241 multiple spaces after ':'

Comment last updated at 2023-12-18 19:09:05 UTC

[bhilbert4]

Note that the edb code will need to be tweaked to look for rowCen and colCen, rather than rowCentroid and colCentroid, per the email from Mario and Neville. See JWSTOSS-8045 for details.