Avoid top-level $ref in Draft 7 and older#170
Open
jviotti wants to merge 1 commit into
Open
Conversation
As per the specification, a subschema defining `$ref` is a "ref object" and EVERY other property MUST be completely ignored. Many implementations (including Blaze), tried to be a bit lenient in these cases, mainly at the root of a schema. However, after discussing some pathological cases, the TSC came into agreement that ANY attempt to make this work, even at the root, can lead to undefined behavior. Therefore, many implementations, including Blaze, will now be more strict on this, completely rejecting Draft 7 and older schemas with a top-level `$ref`. In this PR, I update a few of the test cases that hit this problem. I modified them to make them work exactly like before, so we are not testing more or less than we did before given the workarounds we had in place. Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Contributor
|
It's unclear why the properties are removed from |
Member
Author
|
They were getting ignored before given |
Contributor
|
That makes sense. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the specification, a subschema defining
$refis a "ref object"and EVERY other property MUST be completely ignored.
Many implementations (including Blaze), tried to be a bit lenient in
these cases, mainly at the root of a schema.
However, after discussing some pathological cases, the TSC came into
agreement that ANY attempt to make this work, even at the root, can lead
to undefined behavior. Therefore, many implementations, including Blaze,
will now be more strict on this, completely rejecting Draft 7 and older
schemas with a top-level
$ref.In this PR, I update a few of the test cases that hit this problem. I
modified them to make them work exactly like before, so we are not
testing more or less than we did before given the workarounds we had in
place.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com