Merge scip-kotlin into scip-java#877
Draft
jupblb wants to merge 1 commit into
Draft
Conversation
Imports the scip-kotlin Kotlin compiler plugin (latest commit 8df49a9 from
github.com/sourcegraph/scip-kotlin) into this repository so both indexer
plugins live in a single codebase.
Source code under semanticdb-kotlinc/:
- semanticdb-kotlinc/src/ plugin source + tests + proto
- semanticdb-kotlinc/minimized/src/ snapshot fixtures + golden snaps
Build (build.sbt, project/plugins.sbt):
- new SBT plugins: sbt-kotlin-plugin, sbt-jupiter-interface
- new sbt projects:
* kotlinc — fat-jar via assembly + IntelliJ shading
* kotlincMinimized — uses LOCAL javacPlugin fat-jar (Keys.`package`),
not the published com.sourcegraph:semanticdb-javac,
which avoids NoSuchMethodError on JDK 21 and the
missing-shaded-protobuf-classes error
- top-level kotlincSnapshots task regenerates SCIP snapshots through the
local cli (no separate snapshotsRunner project needed)
- both kotlin projects have compile/test aggregate := false because
kotlinc 2.2.0 requires JDK 11+ (the main matrix runs on JDK 8/11/17/21)
- JavaFormatterPlugin disabled on kotlincMinimized so sbt-java-formatter
does not rewrite the hand-formatted Java fixtures
Snapshots regenerated against the LOCAL javacPlugin and so include the
newer enclosing_range markers and package references that the old published
semanticdb-javac (used by scip-kotlin) did not emit.
CI (.github/workflows/ci.yml):
- new 'kotlin' job (JDK 11) running kotlinc/test, kotlincMinimized/
kotlincSnapshots, and a snapshot drift check (mirrors the previous
scip-kotlin CI)
Misc:
- .gitignore now ignores the kctfork test artifact
(/semanticdb-kotlinc/META-INF/)
- .github/labeler.yml: added graph/scip-kotlin label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
N/A