Fix missing symbols for template functions with enable_if#506
Merged
Conversation
Root cause: In getFunctionDisambiguator(), when handling template function instantiations, the code only handled two cases: 1. Non-templated member functions of class templates 2. Member function templates inside class templates It missed the case of member function templates in non-template classes (like Flashing::bind<T>) and free function templates (like ToString<T>). When getInstantiatedFromMemberTemplate() returned null, definingDecl was left pointing at the instantiated declaration, causing unstable/missing symbols. Fix: Added an else branch to use instantiatedTemplateDecl->getTemplatedDecl() directly when getInstantiatedFromMemberTemplate() returns null.
jupblb
force-pushed
the
michal/gm-issue
branch
from
4460258 to
1704d3d
Compare
Member
Author
|
We have a confirmation that this fix works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: In
getFunctionDisambiguator(), when handling template function instantiations, the code only handled two cases:getInstantiatedFromMemberFunction)getInstantiatedFromMemberTemplate)It missed the case of member function templates in non-template classes (like
Flashing::bind<T>) and free function templates (likeToString<T>). WhengetInstantiatedFromMemberTemplate()returnednull,definingDeclwas left pointing at the instantiated declaration, causing unstable/missing symbols.Fix: Added an else branch to use
instantiatedTemplateDecl->getTemplatedDecl()directly whengetInstantiatedFromMemberTemplate()returns null.