Skip to content

613 fix translations#170

Merged
foobacca merged 2 commits into
mainfrom
613-fix-translations
Jun 12, 2026
Merged

613 fix translations#170
foobacca merged 2 commits into
mainfrom
613-fix-translations

Conversation

@foobacca

Copy link
Copy Markdown
Contributor

Some fixes to ensure errors about the respondent fields are translated.

foobacca and others added 2 commits June 11, 2026 14:33
Wrap the FieldDefinitionConflictError messages surfaced on the schema
page in lazy_gettext so they are translated when flashed. Introduce a
FixedFieldError domain exception so the service recognises the
fixed-field guard by type rather than matching on message text, which
would break under non-English locales.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...p/service_layer/respondent_field_schema_service.py 58.3% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Base automatically changed from 613-require-reg-fields to main June 12, 2026 12:01
@foobacca foobacca marked this pull request as ready for review June 12, 2026 12:01
@foobacca foobacca merged commit 7e1db97 into main Jun 12, 2026
16 of 18 checks passed
@foobacca foobacca deleted the 613-fix-translations branch June 12, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant