[Mellanox] Preserve explicit buffer_model=dynamic in buffer migrator#4609
Open
william8545 wants to merge 1 commit into
Open
[Mellanox] Preserve explicit buffer_model=dynamic in buffer migrator#4609william8545 wants to merge 1 commit into
william8545 wants to merge 1 commit into
Conversation
Guard the traditional-fallback in mlnx_flush_new_buffer_configuration() so it no longer overwrites buffer_model to "traditional" when the device has already declared buffer_model=dynamic. Signed-off-by: William Tsai <willtsai@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard the traditional-fallback in mlnx_flush_new_buffer_configuration() so it no longer overwrites buffer_model to "traditional" when the device has already declared buffer_model=dynamic.
What I did
Fix
MellanoxBufferMigrator.mlnx_flush_new_buffer_configuration()so it no longeroverwrites
DEVICE_METADATA.buffer_modelfromdynamictotraditionalon newerSKUs whose dynamic-mode pool layout is not registered in the migrator's static
mellanox_default_parametertable.How I did it
The fix encodes that precondition into the existing condition rather than introducing a parallel code path.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)