Skip to content

[BMC] Align is_bmc_supported check for the new infra#4584

Open
benle7 wants to merge 1 commit into
sonic-net:masterfrom
benle7:host_bmc_communication
Open

[BMC] Align is_bmc_supported check for the new infra#4584
benle7 wants to merge 1 commit into
sonic-net:masterfrom
benle7:host_bmc_communication

Conversation

@benle7

@benle7 benle7 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

What I did

The BMC support check in generate_dump was aligned with the new infrastructure flow
(sonic-net/sonic-buildimage#26544).
Instead of checking for platform-local bmc.json assumptions, the logic now validates host-side role and runtime BMC data from the canonical source used by the system.

How I did it

  • Updated generate_dump BMC detection to use device_info.is_switch_host() together with
    device_info.get_bmc_data().
  • Removed reliance on legacy platform-folder bmc.json existence behavior for this path.
  • Kept the generate_dump flow behavior intact while aligning detection to runtime
    /etc/sonic/bmc.json-based APIs.

How to verify it

  • Run show techsupport (or generate_dump) on:
    • a switch-host platform with valid BMC data and verify BMC-related flow executes.
    • a non-switch-host / missing-BMC-data platform and verify BMC path is skipped.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ben Levi <belevi@nvidia.com>
@benle7 benle7 force-pushed the host_bmc_communication branch from 3e448be to c6cd2c3 Compare June 7, 2026 06:56
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants