[BMC] Align is_bmc_supported check for the new infra#4584
Open
benle7 wants to merge 1 commit into
Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oleksandrivantsiv
approved these changes
Jun 3, 2026
Signed-off-by: Ben Levi <belevi@nvidia.com>
3e448be to
c6cd2c3
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The BMC support check in
generate_dumpwas aligned with the new infrastructure flow(sonic-net/sonic-buildimage#26544).
Instead of checking for platform-local
bmc.jsonassumptions, the logic now validates host-side role and runtime BMC data from the canonical source used by the system.How I did it
generate_dumpBMC detection to usedevice_info.is_switch_host()together withdevice_info.get_bmc_data().bmc.jsonexistence behavior for this path.generate_dumpflow behavior intact while aligning detection to runtime/etc/sonic/bmc.json-based APIs.How to verify it
show techsupport(orgenerate_dump) on:Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)