Skip to content

Transformer support for oc-system module as per HLD - https://github.com/sonic-net/SONiC/pull/1790#182

Open
Verma-Anukul wants to merge 8 commits into
sonic-net:masterfrom
Verma-Anukul:oc-system-xfmr-implementation
Open

Transformer support for oc-system module as per HLD - https://github.com/sonic-net/SONiC/pull/1790#182
Verma-Anukul wants to merge 8 commits into
sonic-net:masterfrom
Verma-Anukul:oc-system-xfmr-implementation

Conversation

@Verma-Anukul

@Verma-Anukul Verma-Anukul commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

HLD : sonic-net/SONiC#1790

Dependency: SONiC Yang changes in sonic-buildimage : sonic-net/sonic-buildimage#23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - #182

Added Annotation, xfmr support for oc-system module
Also included go test for all the xpaths supported

Features included -
hostname
login & motd banner
timezone
dns
ntp
ssh-server
logging
aaa
processes
messages

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Oct 30, 2025
sonic-buildimage : #23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182

Why I did it
To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790
Some sonic yang changes are required, which is done under this PR

sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179

Work item tracking
NA

How I did it
In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST
to
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST
How to verify it
Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Verma-Anukul

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 182 in repo sonic-net/sonic-mgmt-common

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
sonic-buildimage : sonic-net#23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182

Why I did it
To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790
Some sonic yang changes are required, which is done under this PR

sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179

Work item tracking
NA

How I did it
In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST
to
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST
How to verify it
Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
sonic-buildimage : sonic-net#23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182

Why I did it
To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790
Some sonic yang changes are required, which is done under this PR

sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179

Work item tracking
NA

How I did it
In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST
to
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST
How to verify it
Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine

Signed-off-by: Feng Pan <fenpan@microsoft.com>
xwjiang-ms pushed a commit to xwjiang-ms/sonic-buildimage that referenced this pull request Dec 22, 2025
sonic-buildimage : sonic-net#23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182

Why I did it
To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790
Some sonic yang changes are required, which is done under this PR

sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179

Work item tracking
NA

How I did it
In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST
to
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST
How to verify it
Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine

Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
mhchann pushed a commit to mhchann/sonic-buildimage that referenced this pull request May 7, 2026
sonic-buildimage : sonic-net#23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182

Why I did it
To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790
Some sonic yang changes are required, which is done under this PR

sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179

Work item tracking
NA

How I did it
In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST
to
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST
How to verify it
Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine

Signed-off-by: mhchann <mhchann082@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants