Skip to content

fix regression: reading props.is causes Dynamic component to re-render#2530

Closed
titoBouzout wants to merge 1 commit into
solidjs:mainfrom
titoBouzout:is-regression
Closed

fix regression: reading props.is causes Dynamic component to re-render#2530
titoBouzout wants to merge 1 commit into
solidjs:mainfrom
titoBouzout:is-regression

Conversation

@titoBouzout

@titoBouzout titoBouzout commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Summary

Seems like reading props.is for createElement was causing the Dynamic component to re-render. I've cached it in the same way as the component prop. Introduced by #2514

How did you test this change?

Tested by splicing the fix in the generated code of one of the reproducible bug reports.

Related:
kobaltedev/kobalte#619
https://discord.com/channels/722131463138705510/1404584263755759707
https://discord.gg/solidjs

@changeset-bot

changeset-bot Bot commented Aug 12, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e6a521d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 16902016019

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 86.017%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/scheduler.ts 1 81.08%
Totals Coverage Status
Change from base Build 16791160984: 0.8%
Covered Lines: 2365
Relevant Lines: 2679

💛 - Coveralls

@ryansolid ryansolid closed this in f59ee48 Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants