Feature/compose stability - #42
Merged
Merged
Conversation
Adds the `androidx.compose.runtime:runtime-annotation` dependency to the `model` and `presenter` modules to explicitly mark UI-bound data classes for Compose: - Annotates `Continent`, `Country`, `CountryDetail`, and `Language` models with `@Immutable`. - Annotates `CountryDetailScreen.State` and `CountryListScreen.State` with `@Immutable`. - Annotates `SearchAndFilterScreen.State` with `@Stable`. Also includes minor cleanup, such as removing a redundant type argument in `SearchAndFilterPresenter` and suppressing a version inspection in `libs.versions.toml`.
Deletes the shared Xcode scheme `Countries.xcscheme` from `iosApp/Countries.xcodeproj/xcshareddata/xcschemes/`.
Passing ContentState<List<Country>> as its own parameter gave CountriesList runtime stability: ContentState is a generic library type and List is an interface. The value was already on CountryListScreen.State, which is @immutable, so read it from there instead of whitelisting List. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Annotate `listPaneColor()` in `CountryListUi.kt` with `@ReadOnlyComposable` to optimize its execution, as it only reads composition locals. - Remove the unnecessary `@OptIn(ExperimentalMaterial3AdaptiveApi::class)` from `countriesPaneDirective` in `ListDetailNavDecoration.kt`.
solcott
force-pushed
the
feature/compose_stability
branch
2 times, most recently
from
September 28, 2026 22:54
55e896c to
c94c4dd
Compare
Enable the Compose compiler's metrics and reports via a new `compose.stability` convention plugin, and add a `ComposeStabilityCheckTask` to enforce them. The task reads the generated reports and fails the build if it finds an `unstable` class or an unskippable restartable composable that isn't explicitly accepted in the new `config/compose/` allowlists. Apply the check across all Compose modules (`app`, `apple`, `desktop`, `presenter`, `shared-compose`, `ui`, and `web`). Alongside this, clean up the Kotlin Compose compiler plugin application to use a version catalog alias (`libs.plugins.kotlin.compose`) rather than a root `buildscript` classpath block.
solcott
force-pushed
the
feature/compose_stability
branch
from
September 28, 2026 23:14
c94c4dd to
bd4ea70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.