Repository navigation
49 - #100
Open
pranavvadd wants to merge 2 commits into
Open
49#100pranavvadd wants to merge 2 commits into
pranavvadd wants to merge 2 commits into
Conversation
task 49: update with doc with params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
docs/parameters_needed.md, which lists every currentCarConfigvalue with its unit,owner team (Software/Electrical/Mechanical), source status, and a short note on how it affects
simulation output. Unknown or guessed values are marked.
This work was done by Alex Yung in #81 and merged into the
49branch. It never reachedmain,so this PR brings it in. No code changes.
Checked
CarConfigfields (mass,battery_capacity,solar_panel_area,solar_panel_efficiency,electrical_efficiency,C_dA,tire_pressure,regen_efficiency,rho,g).car_params.json(wheels,battery_voltage,v_starting).main.Related Issue
Closes #49
Notes
parameter chain (Create Rivanna 3S Parameter File #51, Add Parameter Loader For Rich File #52, Add Parameter Schema Validation #53) that Add Conservative/Base/Optimistic Parameter Scenarios #55 was waiting on.
physics.py:21(electrical_efficiencymultiplies instead ofdividing). That is tracked separately in power_drained() formula / mu instead of * mu #26.