Skip to content

Tip support#1620

Merged
franciszekjob merged 9 commits into
developmentfrom
tip-support
Jul 9, 2025
Merged

Tip support#1620
franciszekjob merged 9 commits into
developmentfrom
tip-support

Conversation

@cptartur

@cptartur cptartur commented Jul 8, 2025

Copy link
Copy Markdown
Member

Closes #1601

Introduced changes

  • Added support for tip

  • This PR contains breaking changes
  • Dataclasses representing txs now take tip as an required parameter.
  • Changed interface of BaseAccount so it includes the tip parameter (with default of 0).

@cptartur
cptartur marked this pull request as ready for review July 8, 2025 12:56
Comment thread docs/migration_guide.rst Outdated
Comment thread starknet_py/tests/e2e/account/account_test.py Outdated
Comment thread starknet_py/tests/e2e/contract_interaction/declare_test.py Outdated
Comment thread starknet_py/net/models/transaction.py

@franciszekjob franciszekjob left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth to mention tip functionality somewhere in the guide, maybe in https://starknetpy.readthedocs.io/en/latest/guide/account_and_client.html ?

@cptartur

cptartur commented Jul 9, 2025

Copy link
Copy Markdown
Member Author

Might be worth to mention tip functionality somewhere in the guide, maybe in https://starknetpy.readthedocs.io/en/latest/guide/account_and_client.html ?

Will add that

@cptartur
cptartur force-pushed the tip-support branch 2 times, most recently from b2df515 to 0224716 Compare July 9, 2025 12:03
Base automatically changed from rpc-0.9.0 to development July 9, 2025 13:13
@franciszekjob
franciszekjob merged commit 74527e3 into development Jul 9, 2025
18 of 19 checks passed
@franciszekjob
franciszekjob deleted the tip-support branch July 9, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tip functionality

2 participants