Skip to content

Commit 572c25f

Browse files
committed
changelog and readme updated after previous commit
1 parent 828665e commit 572c25f

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
- upgrade to Kotlin 1.3.10
1111
- upgrade to Spring Boot 2.1.0
1212
- BREAKING CHANGE - all properties are now under a github-crawler prefix
13+
- BREAKING CHANGE - issue #66 : renamed property name from "method" to "type"
1314

1415
### Deprecated
1516

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,27 +84,27 @@ github-crawler:
8484
# name of the indicator that will be reported for that repository in the output
8585
- name: spring_boot_starter_parent_version
8686
# name of the method to find the value in the file, pointing to one of the implementation classes of FileContentParser
87-
method: findDependencyVersionInXml
87+
type: findDependencyVersionInXml
8888
# the parameters to the method, specific to each method type
8989
params:
9090
# findDependencyVersionInXml needs an artifactId as a parameter : it will find the version for that Maven artifact by doing a SAX parsing, even if the version is a ${variable} defined in <properties> section
9191
artifactId: spring-boot-starter-parent
9292
- name: spring_boot_dependencies_version
93-
method: findDependencyVersionInXml
93+
type: findDependencyVersionInXml
9494
params:
9595
artifactId: spring-boot-dependencies
9696
#another file to parse..
9797
Dockerfile:
9898
- name: docker_image_used
9999
# findFirstValueWithRegexpCapture needs a pattern as a parameter. The pattern needs to contain a group capture (see https://regexone.com/lesson/capturing_groups)
100100
# the first match will be returned as the value for this indicator
101-
method: findFirstValueWithRegexpCapture
101+
type: findFirstValueWithRegexpCapture
102102
params:
103103
pattern: ".*\\/(.*)\\s?"
104104

105105
"[src/main/resources/application.yml]":
106106
- name: spring_application_name
107-
method: findPropertyValueInYamlFile
107+
type: findPropertyValueInYamlFile
108108
params:
109109
propertyName: "spring.application.name"
110110

0 commit comments

Comments
 (0)