renaming "method" into "type", for config consistency purpose (#67)

Author: vincent-fuchs

github-crawler-autoconfigure/src/test/java/com/societegenerale/githubcrawler/GitHubCrawlerIT.java

@@ -129,7 +129,7 @@ public void shouldLoadIndicatorsConfig() {
 		IndicatorDefinition pomXmlIndicatorDefinition1 = crawler.getGitHubCrawlerProperties().getIndicatorsToFetchByFile().get(pomXmlFile).get(0);
 		assertThat(pomXmlIndicatorDefinition1).isNotNull();
 		assertThat(pomXmlIndicatorDefinition1.getName()).isEqualTo("spring_boot_starter_parent_version");
-		assertThat(pomXmlIndicatorDefinition1.getMethod()).isEqualTo("findDependencyVersionInXml");
+		assertThat(pomXmlIndicatorDefinition1.getType()).isEqualTo("findDependencyVersionInXml");
 
 		Map params = pomXmlIndicatorDefinition1.getParams();
 		assertThat(params).hasSize(1);

github-crawler-autoconfigure/src/test/resources/application-test.yml

@@ -11,17 +11,17 @@ github-crawler:
   indicatorsToFetchByFile:
     "[pom.xml]":
         - name: spring_boot_starter_parent_version
-          method: findDependencyVersionInXml
+          type: findDependencyVersionInXml
           params:
             artifactId: spring-boot-starter-parent
     Jenkinsfile:
         - name: build_helper_package
-          method: findFirstValueWithRegexpCapture
+          type: findFirstValueWithRegexpCapture
           params:
             pattern: "(?s).*com\\.a\\.given\\.package\\BuildHelpers.*"
     Dockerfile:
         - name: docker_image_used
-          method: findFirstValueWithRegexpCapture
+          type: findFirstValueWithRegexpCapture
           params:
             pattern: "FROM\\s.*\\/(.*)\\s?.*"
 

github-crawler-core/src/main/kotlin/com/societegenerale/githubcrawler/IndicatorDefinition.kt

@@ -2,8 +2,8 @@ package com.societegenerale.githubcrawler
 
 //TODO check regularly on https://github.com/spring-projects/spring-boot/issues/8762 if it's solved.
 // config properties can't binded as immutable values, so we need to have a workaround, declaring all attributes as mutable
-// in previous version, name and method were lateinit, but in that case, it wasn't possible (or I didn't find) a way to set the values in unit tests.
+// in previous version, name and type were lateinit, but in that case, it wasn't possible (or I didn't find) a way to set the values in unit tests.
 // we should roll this back to immutable variables whenever Spring Boot will allow us to do it
 class IndicatorDefinition(var name: String="N/A",
-                          var method: String = "N/A",
+                          var type: String = "N/A",
                           var params: Map<String,String> = HashMap())

github-crawler-core/src/main/kotlin/com/societegenerale/githubcrawler/RepositoryEnricher.kt

@@ -116,7 +116,7 @@ class RepositoryEnricher(val remoteGitHub: RemoteGitHub){
     private fun parseIndicatorsFromFileContent(fileContent: String, pathToFileToGetIndicatorsFrom:String, indicatorsToFetch: List<IndicatorDefinition>): Map<String, String> {
 
         return indicatorsToFetch.asSequence()
-                .map { GitHubCrawler.availableFileContentParsers.get(it.method)!!.parseFileContentForIndicator(fileContent, pathToFileToGetIndicatorsFrom, it) }
+                .map { GitHubCrawler.availableFileContentParsers.get(it.type)!!.parseFileContentForIndicator(fileContent, pathToFileToGetIndicatorsFrom, it) }
                 .reduce { acc, item -> acc + item }
 
     }

github-crawler-core/src/main/resources/application.yml

@@ -16,7 +16,7 @@ github-crawler:
   indicatorsToFetchByFile:
     "[pom.xml]":
     - name: spring_boot_starter_parent_version
-      method: findDependencyVersionInXml
+      type: findDependencyVersionInXml
       params:
         artifactId: spring-boot-starter-parent