Improve snow dcm test and refresh output#3072
Draft
sfc-gh-jsommerfeld wants to merge 2 commits into
Draft
Conversation
sfc-gh-jsommerfeld
force-pushed
the
feature/dcm-test-refresh-improvements
branch
from
c81eb97 to
4cb8804
Compare
sfc-gh-jsommerfeld
changed the base branch from
main
to
feature/dcm-alter-detail-tree
Add a shared "=" divider printed after every DCM reporter's output (Reporter.print_separator) and update the test/refresh reporters and snapshots accordingly. Since the divider is now emitted centrally for all commands, drop compile's bespoke announce_compile_separator() (and COMPILE_SEPARATOR_WIDTH) so compile no longer prints two trailing separator lines. Co-authored-by: Cursor <cursoragent@cursor.com>
sfc-gh-jsommerfeld
force-pushed
the
feature/dcm-test-refresh-improvements
branch
from
4cb8804 to
5a9474d
Compare
test and refresh now render the shared phase checklist (a single TEST / REFRESH phase driven by DeployProgressTracker.run_loader_phase) instead of the legacy generic spinner, matching plan/compile/deploy. - progress: add single-phase "test" and "refresh" operation modes and guard complete_upload() so operations without an UPLOAD phase don't KeyError when run_loader_phase calls it. - styles: collapse the two divergent blues (#a0a8fe and the named "blue") onto a single terminal-default BLUE constant, and route the hardcoded style="blue" literals in progress.py through it, so every blue in DCM output renders the same hue. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
RELEASE-NOTES.md(see when and how).Changes description
...