Add stage encryption type changes#3011
Open
sfc-gh-svasudevan wants to merge 2 commits into
Open
Conversation
Description Testing
sfc-gh-mdrach
left a comment
sfc-gh-mdrach
left a comment
Contributor
There was a problem hiding this comment.
Did we test that this works by default on azure (no override param such as --stage-encryption=SNOWFLAKE_SSE needed?)
Comment on lines
+18439
to
+18443
| | --stage-encryption TEXT SNOWFLAKE_SSE or SNOWFLAKE_FULL for an | | ||
| | auto-created temporary stage; | | ||
| | ignored when --stage is set. Omit for| | ||
| | legacy CREATE STAGE (no ENCRYPTION | | ||
| | clause). | |
Contributor
There was a problem hiding this comment.
looks like the | are crooked
sfc-gh-mdrach
approved these changes
May 12, 2026
sfc-gh-mdrach
left a comment
sfc-gh-mdrach
left a comment
Contributor
There was a problem hiding this comment.
Override is only necessary to cope with deprecated stage mount. https://docs.snowflake.com/en/developer-guide/snowpark-container-services/snowflake-stage-volume#limitations-when-using-the-deprecated-version-of-the-stage-volume-implementation.
Let's confirm that this is still active in customer accounts before proceeding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With snowflake-cli's build-image command, we are unable to use SNOWFLAKE_FULL stage encryption type for CSPs other than AWS.
Hence we will give an option as an argument, where the users can specify what encryption type to use for their temp stages created during this image builder flow.
If they don't specify, we use the default in the account.
Testing
Tested locally against azpreprod3 and preprod8.
Added unit tests for the same.
Sample command:
snow spcs service build-image -c azpp3 --database testsv_demo_1 --schema testsv_demo_1 --compute-pool sv_test_pool --image-repository testsv_demo_1.testsv_demo_1.test_repo --image-name helloworld1 --image-tag v0.1 --eai-name sf_image_build_eai_1 --build-context-dir /home/svasudevan/test-svasudevan-images/ --stage-encryption=SNOWFLAKE_SSEPre-review checklist
Changes description
...