Record partial deletion when archive is trashed but original removal fails - #18
Merged
Merged
Conversation
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
Problem
In the compress-before-trash flow, if
send2trash(archive)succeeded butshutil.rmtree(source)failed, the item landed inresult.failedwith no metadata written. The archive was genuinely in trash, buthistoryanddoctorhad no way to know, so it stayed invisible.Changes
PartialDeletionoutcome onDeleteResult(partial,partial_count), separate fromdeleted/failed.OriginalCleanupError(OSError)carrying the trashedDeletionArchivethrough the rmtree failure.delete_itemsnow routes that case topartialand preserves the archive for recording.statusfield (deleted/partial, defaults todeletedfor legacy records).record_successeswrites partials under the samerun_id.⚠+N partial: archive in trash, original still on disk.doctortreats partial records as valid (flags only unknownstatusas corrupt).test_delete_items_surfaces_error_when_original_removal_fails_after_trashplus version assertions, added aCHANGELOG [Unreleased]note.Verification
ruff check .
ruff format --check .
mypy
pytest
pytest --cov=devklean --cov-report=term-missing
270 passed.