Refactor format task to take --check#3205
Closed
JordonPhillips wants to merge 1 commit into
Closed
Conversation
JordonPhillips
added
the
no-changelog-needed
JordonPhillips
force-pushed
the
refactor-inline-check
branch
2 times, most recently
from
915f270 to
a3e7be8
Compare
This refactors the inline smithyFormat task to accept a `--check` argument instead of reading a gradle property. This is done because it prevents check-mode from being toggled on when you're not explicitly running the check task. The task had to be updated from a fully-inline definition to a more static definition to be able to accept an explicit arg like that.
JordonPhillips
force-pushed
the
refactor-inline-check
branch
from
a3e7be8 to
997bea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the inline smithyFormat task to accept a
--checkargument instead of reading a gradle property. This is done because it prevents check-mode from being toggled on when you're not explicitly running the check task.The task had to be updated from a fully-inline definition to a more static definition to be able to accept an explicit arg like that.
See also: smithy-lang/smithy-gradle-plugin#168
This is in draft until the above is released because we need the gradle task to also be supporting
--check.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.