Repository navigation
Conversation
So that anyone who uses any module from smithy-java gets the BOM automatically applied in Gradle
timocov
force-pushed
the
bom-platform-alignment
branch
from
October 25, 2026 12:15
9c7b0d5 to
eb63694
Compare
timocov
commented
Oct 25, 2026
| ApplyHttpRetryInfoPlugin.class, | ||
| RequestCompressionPlugin.class, | ||
| HttpChecksumPlugin.class, | ||
| SimpleAuthDetectionPlugin.class, |
Contributor
Author
There was a problem hiding this comment.
The order of loaded plugins changed, it doesn't feel like a big deal considering that plugins aren't ordered by default, but let me know. (maybe test check should not rely on the order?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
There is a chance that a consumer of smithy-java can get modules of different versions (e.g. core:1.6.0 and io:1.8.0) which can cause problems in runtime. There is already a mechanism that fails the startup to avoid such issues (done via
version-spimodule). But it feels like we can go one step further (at least for Gradle users) and add BOM cross-reference to every published module so that when say you getcore:1.6.0you also automatically getbom:1.6.0, and if you also getio:1.8.0it will come withbom:1.8.0and then Gradle will pickbom:1.8.0and align versions for both used modules.Why is this change needed?
To reduce number of version mismatches when using clients published with different smithy-java versions and address the issue earlier (than just failing at the startup).
How was this validated?
pTMLworks too and each published module contains reference tosoftware.amazon.smithy.java:bom:{currentSmithyJavaVersion}What should reviewers focus on?
Due to the way smithy-base gradle plugin works, it resolves
runtimeClasspathduring configuration to detect smithy cli version which causes "cannot modify after observing" error from Gradle. In order to overcome this, I explicitly addedsmithy-clidependency tosmithyCliconfiguration with the version being aligned to current smithy version. It doesn't change the version - it is still aligned with the rest of the modules, but just something that might not be obvious (but it is worth nothing that this is something anyone with strict dependency locking has to do anyway, otherwise you will get similar error).Additional Links
For instance, jackson-core has the same: https://repo1.maven.org/maven2/tools/jackson/core/jackson-core/3.1.0/jackson-core-3.1.0.module (in this case
jackson-corereferencesjackson-bom).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.